Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRE Executors #2499

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

LRE Executors #2499

wants to merge 9 commits into from

Conversation

purva-thakre
Copy link
Contributor

@purva-thakre purva-thakre commented Sep 11, 2024

Description

Fixes #2370

List of todos:

  • Docstrings
  • Additional unit tests

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (1a3705c) to head (9146116).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2499   +/-   ##
=======================================
  Coverage   98.71%   98.72%           
=======================================
  Files          89       90    +1     
  Lines        4131     4157   +26     
=======================================
+ Hits         4078     4104   +26     
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre force-pushed the lre_Executor branch 2 times, most recently from e328b9d to 52e0812 Compare September 11, 2024 19:10
@purva-thakre purva-thakre marked this pull request as ready for review September 13, 2024 09:41
@purva-thakre
Copy link
Contributor Author

purva-thakre commented Sep 13, 2024

This test does not fail locally: https://github.com/unitaryfund/mitiq/actions/runs/10847148259/job/30101612145?pr=2499#step:6:4556

Will dig into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executors for LRE
1 participant