Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SUSE Liberty Linux Base Media section #3120

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Jun 25, 2024

Description

This PR

  • removes the base media section for SUSE Linux Liberty. According to @rjmateus, this is not necessary
  • fixes a layout issue on the Liberate page

Target branches

  • master
  • 4.3.13 MU

Backport targets (edit as needed):

  • master
  • 4.3

Links

For Liberty Linux this is not necessary according to Ricardo.

Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
@nodeg
Copy link
Member Author

nodeg commented Jun 25, 2024

Please also add @rjmateus and @admd to the reviewers.

@admd admd requested review from mcalmer and keichwa June 25, 2024 15:02
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if you need the media or not.

@rjmateus
Copy link
Member

We tested the SLL migration with the liberate formula without the media and it worked. As far as I know, it's only needed if we want to install a new system.

CHANGELOG.md Outdated Show resolved Hide resolved
@keichwa keichwa requested a review from mcalmer June 26, 2024 04:15
@mcalmer
Copy link
Contributor

mcalmer commented Jun 26, 2024

We tested the SLL migration with the liberate formula without the media and it worked. As far as I know, it's only needed if we want to install a new system.

But that chapter is not exclusivly for liberty migration. Customers may want to perform a new installation. We remove now important Informationen

@keichwa keichwa self-requested a review June 26, 2024 06:05
@keichwa
Copy link
Contributor

keichwa commented Jun 26, 2024

We tested the SLL migration with the liberate formula without the media and it worked. As far as I know, it's only needed if we want to install a new system.

But that chapter is not exclusivly for liberty migration. Customers may want to perform a new installation. We remove now important Informationen

Ok, I'll take a closer look! @Others - do not hesitate to share your thoughts and proposals to solve this dilemma.

@keichwa
Copy link
Contributor

keichwa commented Jun 26, 2024

But that chapter is not exclusivly for liberty migration. Customers may want to perform a new installation. We remove now important Informationen

Maybe, a better place for client installation instructions is in the Autoinstallation chapter: https://documentation.suse.com/suma/5.0/en/suse-manager/client-configuration/autoinst-distributions.html. In the clients-*.adoc files we assume the client is up and running, and should now registered to the manager. OTOH, I wouldn't mind add an excursion or appendix to the clients-*.adoc files where we provide basic info about client installation from scratch.

Now we must decide how we should fix the raised issue for the currents releases (5.x and 4.3.x) and then how we want to structure the chapters of the Client Config Guide in general.

@admd
Copy link
Contributor

admd commented Jun 26, 2024

There is a lot of useful information here that is being removed that is important to understand the overall picture around Liberty. I don't think we need to merge this now and rather handle this later when we have some more time. I would suggest to change it back to draft so it doesn't get merged by mistake.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@0rnela 0rnela marked this pull request as draft June 26, 2024 08:50
@0rnela
Copy link
Contributor

0rnela commented Jun 26, 2024

There is a lot of useful information here that is being removed that is important to understand the overall picture around Liberty. I don't think we need to merge this now and rather handle this later when we have some more time. I would suggest to change it back to draft so it doesn't get merged by mistake.

Converted back to DRAFT.

@nodeg
Copy link
Member Author

nodeg commented Jun 26, 2024

But that chapter is not exclusivly for liberty migration. Customers may want to perform a new installation. We remove now important Informationen

That is correct. That is why I asked Ricardo again here: https://suse.slack.com/archives/C02D12TNYLS/p1719324925029689:

[...] but at least the 1.1 section, looks to me it can be removed: https://documentation.suse.com/suma/5.0/en/suse-manager/client-configuration/clients-sleses.html#add.base.media

@rjmateus
Copy link
Member

Michael has a good point. I will not harm the customer by keeping this in here, and someone may need it. Lets keeps this section, and close this PR so as not merged and not risk merging it. We can remove it in the future If needed.

@keichwa
Copy link
Contributor

keichwa commented Jun 26, 2024

I'll move my comment #3120 (comment) to our team board. Next time we can discuss how we can further improve the Client Config Guide. Thanks to Ornela, it looks nice and structure is generally good. But at some places, we either could add more details, exchange some sections, or need better intro texts (book, chapters, sections).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants