docs: explain constraint validation, add error messages #3640
Conversation
github-actions
bot
added
the
Language unchecked
vursen
changed the title
vursen
changed the title
| @@ -193,10 +193,16 @@ The pattern is a regular expression used to validate the full value entered into | |||
| [%collapsible] | |||
| ==== | |||
| A separate single-character, regular expression can be used to restrict the characters that can be entered into the field. Characters that don't match the expression are rejected. | |||
|
|
|||
| However, programmatically set values are not subject to this restriction, even if they contain disallowed characters. To validate these values, a pattern constraint should be used additionally. | |||
There was a problem hiding this comment.
I wanted to add this note but I've realized there is a complication. ComboBox and MultiSelectComboBox both have setAllowedCharPattern, but they don't have setPattern or if they do, it doesn't work, see vaadin/flow-components#6635.
I'm now not sure. I wonder whether there is actually a use-case for setAllowedCharPattern for MultiSelectComboBox. At first glance, the required constraint seems to be the only reasonable.
There was a problem hiding this comment.
I guess you could have a CB where you should only be able to enter numbers or something. In any case, both pattern and allowChars are really only meaningful for custom entry. I'd mention it as planned for now and see if we can fix 6635.
| @@ -144,7 +144,7 @@ Disabled fields can be useful in situations where they can become enabled based | |||
|
|
|||
|
|
|||
| //// | |||
| CONSTRAINT FEATURES | |||
| VALIDATION FEATURES | |||
| //// | |||
|
|
|||
| // tag::constraints-intro[] | |||
There was a problem hiding this comment.
Can't comment an unchanged line, but shouldn't the heading below also say Validation?
| @@ -193,10 +193,16 @@ The pattern is a regular expression used to validate the full value entered into | |||
| [%collapsible] | |||
| ==== | |||
| A separate single-character, regular expression can be used to restrict the characters that can be entered into the field. Characters that don't match the expression are rejected. | |||
|
|
|||
| However, programmatically set values are not subject to this restriction, even if they contain disallowed characters. To validate these values, a pattern constraint should be used additionally. | |||
There was a problem hiding this comment.
I guess you could have a CB where you should only be able to enter numbers or something. In any case, both pattern and allowChars are really only meaningful for custom entry. I'd mention it as planned for now and see if we can fix 6635.
Co-authored-by: Rolf Smeds <[email protected]>
Co-authored-by: Rolf Smeds <[email protected]>
Co-authored-by: Rolf Smeds <[email protected]>
Co-authored-by: Rolf Smeds <[email protected]>
Co-authored-by: Rolf Smeds <[email protected]>
Co-authored-by: Rolf Smeds <[email protected]>
Explains constraint validation and updates the examples to use new i18n error messages for:
Part of #3548