Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add daily active users license model documentation #3658

Open
wants to merge 15 commits into
base: latest
Choose a base branch
from
Open

feat: Add daily active users license model documentation #3658

wants to merge 15 commits into from
+267 −3

Conversation

mshabarov
Copy link
Contributor

No description provided.

mcollovati and others added 4 commits September 4, 2024 16:28
@mcollovati
feat: add DAU documentation
6c5d789
@mcollovati @tltv
feat: document DAUCustomizer interface (#3648)
cc05be7 
* feat: document DAUCustomizer interface

* Apply suggestions from code review

Co-authored-by: Tomi Virtanen <[email protected]>

* vale fixes

* vale fixes

---------

Co-authored-by: Tomi Virtanen <[email protected]>
@mshabarov
feat: Add DAU general description (#3653)
622cb43 
* feat: Add DAU general description

* add a note about sub key and app name prefix

* fix lint issues

* fix review comments
@mshabarov
Merge branch 'latest' into feat/dau
ca0f85d
@github-actions github-actions bot added the Language unchecked English language check has not been done label Sep 12, 2024
@mshabarov mshabarov marked this pull request as ready for review September 13, 2024 06:32
@mcollovati
Copy link
Contributor

I think we should update this phrase in the Licenses page

In general, you don’t need a license after deploying an application to production. The only exception is Collaboration Kit, which requires a license for production use, and it’s priced per end user. See Collaboration Kit documentation for details.

With DAU introduction, also Premium requires the license for production use.

@mshabarov
Copy link
Contributor Author

I think we should update this phrase in the Licenses page

Changed.

Legioth
Legioth reviewed Sep 16, 2024
View reviewed changes
articles/flow/configuration/licenses/daily-active-users.adoc Outdated Show resolved Hide resolved
articles/flow/configuration/licenses/daily-active-users.adoc Outdated Show resolved Hide resolved
articles/flow/configuration/licenses/daily-active-users.adoc Outdated Show resolved Hide resolved
articles/flow/configuration/licenses/daily-active-users.adoc Outdated

After the grace period has ended, if the limit hasn't been increased:

- if DAU limit is reached on *3 consecutive days*, the DAU limit is enforced and application responds with `Service Unavailable` error - not allowing additional end-users that day
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could rephrase the end to make it even clearer that the app remains functional for existing users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"active" can also be misunderstood. How about "but remaining fully functional for users that were counted before the limit was reached"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

articles/flow/configuration/licenses/daily-active-users.adoc Outdated Show resolved Hide resolved
articles/flow/configuration/licenses/daily-active-users.adoc Outdated Show resolved Hide resolved
articles/flow/configuration/licenses/daily-active-users.adoc Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Legioth Legioth Legioth left review comments

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
Language unchecked English language check has not been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshabarov @mcollovati @Legioth