Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Adding the generic map handler and config set, get commands for standalone. #2303

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Go: Adding the generic map handler and config set, get commands for standalone. #2303

merged 5 commits into from
Sep 19, 2024

Conversation

janhavigupta007
Copy link
Collaborator

  • Implementation of config|get and config|set commands for standalone client.
  • Handling of Map data structure for all the primitive types in rust (lib.rs).

@janhavigupta007 janhavigupta007 requested a review from a team as a code owner September 17, 2024 06:51
@janhavigupta007 janhavigupta007 added the go golang wrapper label Sep 17, 2024
@janhavigupta007 janhavigupta007 mentioned this pull request Sep 17, 2024
Open
ravisi21
ravisi21 approved these changes Sep 17, 2024
View reviewed changes
go/api/response_handlers.go Outdated Show resolved Hide resolved
go/src/lib.rs Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Sep 17, 2024
View reviewed changes
go/api/glide_client.go Outdated Show resolved Hide resolved
go/api/glide_client.go Show resolved Hide resolved
go/api/response_handlers.go Show resolved Hide resolved
go/integTest/standalone_commands_test.go Show resolved Hide resolved
go/integTest/standalone_commands_test.go Outdated Show resolved Hide resolved
go/src/lib.rs
}

/// Frees the error_message received on a command failure.
/// TODO: Add a test case to check for memory leak.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

go/utils/transform_utils.go Show resolved Hide resolved
@janhavigupta007 janhavigupta007 self-assigned this Sep 18, 2024
umit
umit reviewed Sep 18, 2024
View reviewed changes
go/utils/transform_utils.go Outdated Show resolved Hide resolved
@janhavigupta007 janhavigupta007 changed the title Adding the generic map handler and config set, get commands for standalone. Go: Adding the generic map handler and config set, get commands for standalone. Sep 18, 2024
Yury-Fridlyand
Yury-Fridlyand approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming other comments are addressed

go/integTest/glide_test_suite_test.go
@@ -21,7 +21,7 @@ type GlideTestSuite struct {
suite.Suite
standalonePorts []int
clusterPorts []int
redisVersion string
serverVersion string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

go/integTest/glide_test_suite_test.go Show resolved Hide resolved
go/integTest/glide_test_suite_test.go Outdated Show resolved Hide resolved
@janhavigupta007 janhavigupta007 merged commit 09b2219 into valkey-io:main Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umit umit umit left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@ravisi21 ravisi21 ravisi21 approved these changes

@eifrah-aws eifrah-aws Awaiting requested review from eifrah-aws

Assignees

@janhavigupta007 janhavigupta007

Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janhavigupta007 @umit @Yury-Fridlyand @ravisi21