Node: fix pubsub IT #2317
Merged
Node: fix pubsub IT #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
added
Release blocker
node
testing
Valkey-8
acarbonetto
approved these changes
Sep 18, 2024
shohamazon
approved these changes
Sep 19, 2024
|
@Yury-Fridlyand did you make sure this does not happen in other cluster-only tests? |
|
I run all pubsub IT on valkey 8 with this fix on another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #2296
Removing standalone client from a test which checks
numsubandshardnumsubtogether, because shard commands available on cluster only. Those commands are checked in other tests.fixes: #2327