-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add missing exports #2321
base: release-1.1
Are you sure you want to change the base?
Python: Add missing exports #2321
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add JSON types
also, CI is red |
Added, CI fixed |
@@ -289,7 +290,9 @@ async def main( | |||
if clients_to_run == "all" or clients_to_run == "glide": | |||
# Glide Socket | |||
client_class = GlideClusterClient if is_cluster else GlideClient | |||
config = BaseClientConfiguration( | |||
config = GlideClusterClientConfiguration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated - please revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind - this fixes the removal of the BaseClientConfiguration from our exports. 👍
Signed-off-by: Andrew Carbonetto <[email protected]>
This reverts commit a26ca32. Signed-off-by: Andrew Carbonetto <[email protected]>
Sibling of #2301