fix(runtime-core): handle nested reactive object in guardReactiveProps #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
edison1105
reviewed
Aug 23, 2024
| setup() { | ||
| const { obj } = toRefs(state) | ||
| setTimeout(async () => { | ||
| state.obj.style.color = 'yellow' |
There was a problem hiding this comment.
Why not move those 3 lines to the end of this case?
edison1105
added
the
🍰 p2-nice-to-have
edison1105
changed the title
edison1105
reviewed
Aug 23, 2024
packages/runtime-core/src/vnode.ts
Outdated
| function generateProps(props: Data & VNodeProps) { | ||
| const target: Data & VNodeProps = {} | ||
| for (const key in props) { | ||
| if (isProxy(props[key])) { |
There was a problem hiding this comment.
should check props[key] is Object first.
consider the following situation:
const state = reactive({
title: 'hi',
obj: {
style: {
color: 'red',
},
},
})In theory, only 2 layers of nesting need to be handled here, and for safety, maybe it is necessary to deal with deep recursive processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11691
this pr playground