Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VTCodeGroup more stylish #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

the-pesar
Copy link

@the-pesar the-pesar commented Dec 7, 2023

I Think this is better style

@Jinjiang
Copy link
Member

Could you please elaborate more like your use cases, and the what the style looks like in that case before and after the change. Thanks.

@the-pesar
Copy link
Author

the-pesar commented Dec 13, 2023

I recently added VTCodeGroup to vuejs/docs (2595)
I think that Tabs are not beautiful/standard enough.
Thanks. @Jinjiang

Before:

Screenshot from 2023-12-13 17-37-05

After:

image

@Jinjiang
Copy link
Member

@the-pesar thanks for the information. Well, I personally feel the original design is fine. The font of the tabs is proportional and as same as other content (defined in .vt-doc). While the font of the code content is monospaced and as same as other code content. So please don't mind me holding this PR for more team members looking into this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants