Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IN-3927): UDM enhancements #1483

Merged
merged 7 commits into from
Jan 24, 2024
Merged

feat(IN-3927): UDM enhancements #1483

merged 7 commits into from
Jan 24, 2024

Conversation

Razz21
Copy link
Contributor

@Razz21 Razz21 commented Jan 22, 2024 •
edited
Loading

🔗 Linked issue

https://vsf.atlassian.net/browse/IN-3927

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • updating default query / mutations to match UDM requirements
    • CategorySearchQuery
    • CategoryListQuery
    • ProductListsQuery

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f0261ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vue-storefront/magento-api Minor
@vue-storefront/magento-types Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bartoszherba bartoszherba force-pushed the feat/IN-3927-udm-enhancements-1 branch from 4445a89 to 811cfb0 Compare January 23, 2024 10:43
@Razz21 Razz21 marked this pull request as ready for review January 23, 2024 12:15
@Razz21 Razz21 requested a review from a team as a code owner January 23, 2024 12:15
bartoszherba
bartoszherba requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@bartoszherba bartoszherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add changeset yarn changeset from the root

bartoszherba
bartoszherba previously approved these changes Jan 23, 2024
View reviewed changes
@Razz21 Razz21 merged commit e3a461c into main Jan 24, 2024
8 checks passed
@Razz21 Razz21 deleted the feat/IN-3927-udm-enhancements-1 branch January 24, 2024 06:30
Razz21 added a commit that referenced this pull request Jan 24, 2024
@Razz21
Revert "feat(IN-3927): UDM enhancements (#1483)"
ca6cb81 
This reverts commit e3a461c.
Razz21 added a commit that referenced this pull request Jan 24, 2024
@Razz21
Revert "feat(IN-3927): UDM enhancements (#1483)" (#1485)
fce1d87 
This reverts commit e3a461c.
@Razz21 Razz21 restored the feat/IN-3927-udm-enhancements-1 branch January 24, 2024 08:54
@Razz21 Razz21 deleted the feat/IN-3927-udm-enhancements-1 branch January 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszherba bartoszherba bartoszherba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razz21 @bartoszherba