refactor: standarize API Client #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a948cf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sethidden
commented
Mar 28, 2024
sethidden
commented
Mar 28, 2024
sethidden
force-pushed
the
IN-4072-proxy-sdk
branch
from
0aa5752
to
6089e80
Compare
sethidden
commented
Mar 28, 2024
sethidden
commented
Mar 28, 2024
sethidden
force-pushed
the
IN-4072-proxy-sdk
branch
from
6089e80
to
566f48e
Compare
Somebody changed the magento store config and didnt tell anybody
WojtekTheWebDev
previously approved these changes
Apr 10, 2024
WojtekTheWebDev
previously approved these changes
Apr 10, 2024
bartoszherba
previously approved these changes
Apr 10, 2024
WojtekTheWebDev
dismissed stale reviews from bartoszherba and themself
via
37d3e34
WojtekTheWebDev
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
IN-4072
❓ Type of change
📚 Description
Standarizes Magento API Client by changing the Endpoints interface, adding ApiMethods interface and refactoring the api methods to be async functions.
📝 Checklist