Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing endpoints type export #1526

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: missing endpoints type export #1526

merged 3 commits into from
May 10, 2024

Conversation

grixu
Copy link
Contributor

@grixu grixu commented May 9, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@grixu grixu self-assigned this May 9, 2024
@grixu grixu requested a review from a team as a code owner May 9, 2024 13:14
Copy link

changeset-bot bot commented May 9, 2024

πŸ¦‹ Changeset detected

Latest commit: a625bae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/magento-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

"@vue-storefront/magento-api": patch
---

Fix missing export of Endpoints type
Copy link
Collaborator

@bartoszherba bartoszherba May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

Copy link
Collaborator

@bartoszherba bartoszherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update changeset according to the rfc

@grixu grixu requested a review from bartoszherba May 10, 2024 07:37
@grixu grixu merged commit 101d990 into main May 10, 2024
4 of 6 checks passed
@grixu grixu deleted the fix/missing-endpoints-export branch May 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants