refactor: Separate pyevm implementation from environment #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation to handle vyperlang#104
DanielSchiavini
changed the title
boa/vm/py_evm.py
Outdated
| return self.vm.state.snapshot() | ||
|
|
||
| def anchor(self): | ||
| return self.vm.patch.anchor() |
There was a problem hiding this comment.
this should probably anchor evm state
DanielSchiavini
force-pushed
the
104/refactor-pyevm
branch
from
18e821c
to
913840e
Compare
boa/vm/py_evm.py
Outdated
| self.vm = self.chain.get_vm() | ||
| self.vm.__class__._state_class.account_db_class = account_db_class | ||
|
|
||
| self.vm.patch = VMPatcher(self.vm) |
There was a problem hiding this comment.
we can probably promote VMPatcher to self.patch instead of inside of self.vm
There was a problem hiding this comment.
(it should probably be part of our "EVM API")
charles-cooper
approved these changes
Apr 17, 2024
DanielSchiavini
added a commit
to DanielSchiavini/titanoboa
that referenced
this pull request
May 6, 2024
… assignment This was caused by a typo, the property block_id was removed in vyperlang#134 Another typo broke the time travel tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I have separated the
environmentlogic from the pyevm implementation details.How I did it
How to verify it
Description for the changelog
N/A
Cute Animal Picture