-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Jupyter tests #169
Merged
Merged
chore: Jupyter tests #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
changed the title
chore: Jupyter plugin simplify and test
chore: Jupyter tests
Feb 20, 2024
dev-requirements.txt
Outdated
@@ -12,3 +12,6 @@ pytest | |||
pytest-xdist | |||
pytest-cov | |||
sphinx-rtd-theme | |||
jupyter_server | |||
ipython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dup
DanielSchiavini
force-pushed
the
jupyter
branch
from
February 21, 2024 14:44
364dc27
to
cd0f5dc
Compare
charles-cooper
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Separate job to run the jupyter tests with proper dependencies installed.
How I did it
How to verify it
Plugin should keep working. Unit tests should be green.
Description for the changelog
N/A
Cute Animal Picture