Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 Rails 3.1.3 #608

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ruby 3.3 Rails 3.1.3 #608

wants to merge 5 commits into from

Conversation

jasonfine
Copy link
Member

Some notable things:

  1. The highlight color test is flickering, I've noted my findings at the top of /spec/features/highlight_spec.rb. Spent some time wheel spinning on fixes for it but nothing seems to be a workable solution. It seems to be related to the database_cleaner removing records in the middle of the test. I've confirmed the functionality in the tests is fully working in the dummy app.
  2. Removed the datadog connection since we aren't really using that anymore.
  3. Locked Carrierwave to 2.2.6. 3.x is introducing weird file renaming behavior when cloning attachments. Cloned attachments should be keeping their original filename, 3.x is adding a _2_.ext to the duplicated filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant