Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FilterEntity instead of Filter #3703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcscottiii
Copy link
Collaborator

The datastore library has marked Filter as deprecated. By moving to FilterEntity, we can use more advanced queries as well.

This commit introduces a new EntityFilter type. That type just wraps datastore.EntityFilter because there are no exposed methods on datastore.EntityFilter for us to manually declare.

In order to create an EntityFilter, another type called FilterBuilder is created which will allow consumers to make a particular Filter that reteurns an EntityFilter.

More about the deprecation here: https://pkg.go.dev/cloud.google.com/go/datastore#Query.Filter

The datastore library has marked Filter as deprecated. By moving to
FilterEntity, we can use more advanced queries as well.

This commit introduces a new EntityFilter type. That type just wraps
datastore.EntityFilter because there are no exposed methods on
datastore.EntityFilter for us to manually declare.

In order to create an EntityFilter, another type called FilterBuilder is
created which will allow consumers to make a particular Filter that
reteurns an EntityFilter.

More about the deprecation here: https://pkg.go.dev/cloud.google.com/go/datastore#Query.Filter
@jcscottiii jcscottiii force-pushed the migrate-from-deprecated-filter branch from aab6a25 to d1daaf0 Compare February 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant