Merge pull request #1148 from webrtcHacks/remove-old-getdisplaymedia

Remove Chrome getDisplayMedia shim
webrtcHacks · Mar 24, 2024 · 1868c93 · 1868c93
2 parents 13c8980 + fdf88a4
commit 1868c93
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 147 deletions.
diff --git a/src/js/chrome/chrome_shim.js b/src/js/chrome/chrome_shim.js
@@ -10,7 +10,6 @@
 import * as utils from '../utils.js';
 
 export {shimGetUserMedia} from './getusermedia';
-export {shimGetDisplayMedia} from './getdisplaymedia';
 
 export function shimMediaStream(window) {
   window.MediaStream = window.MediaStream || window.webkitMediaStream;

diff --git a/src/js/chrome/getdisplaymedia.js b/src/js/chrome/getdisplaymedia.js
diff --git a/test/unit/chrome.test.js b/test/unit/chrome.test.js
@@ -60,100 +60,4 @@ describe('Chrome shim', () => {
       shim.shimGetUserMedia(window);
     });
   });
-
-  describe('getDisplayMedia shim', () => {
-    const getSourceId = jest.fn().mockReturnValue(Promise.resolve('abc'));
-
-    it('does not overwrite an existing ' +
-        'navigator.mediaDevices.getDisplayMedia', () => {
-      window.navigator.mediaDevices.getDisplayMedia = 'foo';
-      shim.shimGetDisplayMedia(window, getSourceId);
-      expect(window.navigator.mediaDevices.getDisplayMedia).toBe('foo');
-    });
-
-    it('does not if navigator.mediaDevices does not exist', () => {
-      delete window.navigator.mediaDevices;
-      shim.shimGetDisplayMedia(window);
-      expect(window.navigator.mediaDevices).toBe(undefined);
-    });
-
-    it('shims navigator.mediaDevices.getDisplayMedia', () => {
-      shim.shimGetDisplayMedia(window, getSourceId);
-      expect(typeof window.navigator.mediaDevices.getDisplayMedia)
-        .toBe('function');
-    });
-
-    it('calls getUserMedia with the sourceId', async() => {
-      shim.shimGetDisplayMedia(window, getSourceId);
-      await window.navigator.mediaDevices.getDisplayMedia({video: true});
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls.length)
-        .toBe(1);
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls[0][0])
-        .toEqual({
-          video: {
-            mandatory: {
-              chromeMediaSource: 'desktop',
-              chromeMediaSourceId: 'abc',
-              maxFrameRate: 3,
-            }
-          }
-        });
-    });
-
-    it('translates frameRate to legacy maxFrameRate', async() => {
-      shim.shimGetDisplayMedia(window, getSourceId);
-      await window.navigator.mediaDevices
-        .getDisplayMedia({video: {frameRate: 25}});
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls.length)
-        .toBe(1);
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls[0][0])
-        .toEqual({
-          video: {
-            mandatory: {
-              chromeMediaSource: 'desktop',
-              chromeMediaSourceId: 'abc',
-              maxFrameRate: 25,
-            }
-          }
-        });
-    });
-
-    it('translates width to legacy maxWidth', async() => {
-      shim.shimGetDisplayMedia(window, getSourceId);
-      await window.navigator.mediaDevices
-        .getDisplayMedia({video: {width: 640}});
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls.length)
-        .toBe(1);
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls[0][0])
-        .toEqual({
-          video: {
-            mandatory: {
-              chromeMediaSource: 'desktop',
-              chromeMediaSourceId: 'abc',
-              maxFrameRate: 3,
-              maxWidth: 640,
-            }
-          }
-        });
-    });
-
-    it('translates height to legacy maxHeight', async() => {
-      shim.shimGetDisplayMedia(window, getSourceId);
-      await window.navigator.mediaDevices
-        .getDisplayMedia({video: {height: 480}});
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls.length)
-        .toBe(1);
-      expect(window.navigator.mediaDevices.getUserMedia.mock.calls[0][0])
-        .toEqual({
-          video: {
-            mandatory: {
-              chromeMediaSource: 'desktop',
-              chromeMediaSourceId: 'abc',
-              maxFrameRate: 3,
-              maxHeight: 480,
-            }
-          }
-        });
-    });
-  });
 });