Added qr code generation

[joshterrill]

Related to #94, added qr code generation upon torrent file selection. Maybe we want to make the QR code larger? Or position it somewhere else? I figured this was fine for right now.

[feross]

Small bug: If there's already a hash in the URL, this will add a second one.

[feross]

You don't need to commit the qrcode.min.js file, since you're already using require to include the package.

[feross]

One thing that's a bit of a bummer is that this single dependency almost doubles the size of the JS bundle.

cat static/bundle.js | gzip | wc -c
  144612
browserify -r node-qr-image | gzip | wc -c
  103611

[feross]

Other than my comments, this looks good!

If you know another dependency that's a bit lighter weight than this, let's swap it in.

[joshterrill]

Actually that js file shouldn't even be there. My bad. That was for another
one I was testing out. And yeah ill look for another dependency... most of
the other ones I looked at required some sort of C libraries that I didn't
have installed so I figured it would be bad to use those. But I will still
look around.
On Mar 18, 2016 11:26 PM, "Feross Aboukhadijeh" [email protected]
wrote:

Other than my comments, this looks good!

If you know another dependency that's a bit lighter weight than this,
let's swap it in.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/feross/instant.io/pull/104#issuecomment-198647711

[feross]

No problem if you can't find one. We can still merge this. But there's no way that QR generation can require that much code.

[feross]

It looks like most of the size of node-qr-image comes from bundling a zlib library. We should just find a library that uses canvas to draw the image. You can even get a PNG from a canvas without manually making the PNG yourself ;)

[joshterrill]

Woops, forgot this was here. I'll take care of this and fix what needs to be fixed this week.

[feross]

Hey @joshterrill, no pressure, just wondering if you plan to finish up this PR? If not, no worries. Just let me know.

[joshterrill]

Sure I can do it. What do you think about using something like this? https://github.com/alexeyten/qr-image

[feross]

Looks like a good library to me.