Skip to content

Merge pull request #300 from Schmiddiii/decrypt-device-info #229

Merge pull request #300 from Schmiddiii/decrypt-device-info

Merge pull request #300 from Schmiddiii/decrypt-device-info #229

Triggered via push June 7, 2024 16:43
Status Failure
Total duration 57s
Artifacts

pages.yaml

on: push
GitHub Pages
48s
GitHub Pages
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 38 warnings
GitHub Pages
failed to run custom build command for `libsignal-protocol v0.1.0 (https://github.com/signalapp/libsignal?tag=v0.40.1#f980fccd)`
GitHub Pages
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
GitHub Pages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
GitHub Pages
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
direct implementation of `ToString`: libsignal-service/src/configuration.rs#L99
warning: direct implementation of `ToString` --> libsignal-service/src/configuration.rs:99:1 | 99 | / impl ToString for SignalServers { 100 | | fn to_string(&self) -> String { 101 | | match self { 102 | | Self::Staging => "staging", ... | 106 | | } 107 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the function `message_decrypt_prekey` doesn't need a mutable reference: libsignal-service/src/cipher.rs#L185
warning: the function `message_decrypt_prekey` doesn't need a mutable reference --> libsignal-service/src/cipher.rs:185:21 | 185 | &mut self.protocol_store.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: libsignal-service/src/account_manager.rs#L879
warning: this expression creates a reference which is immediately dereferenced by the compiler --> libsignal-service/src/account_manager.rs:879:35 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^ help: change this to: `aci.private_key()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: libsignal-service/src/account_manager.rs#L879
warning: question mark operator is useless here --> libsignal-service/src/account_manager.rs:879:5 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `crate::decrypt_device_name(&aci.private_key(), &name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
called `is_none()` after searching an `Iterator` with `find`: libsignal-service/src/account_manager.rs#L746
warning: called `is_none()` after searching an `Iterator` with `find` --> libsignal-service/src/account_manager.rs:746:24 | 746 | if pni_registration_ids | ________________________^ 747 | | .iter() 748 | | .find(|(_k, v)| **v == regid) 749 | | .is_none() | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some = note: `#[warn(clippy::search_is_some)]` on by default help: consider using | 746 ~ if !pni_registration_ids 747 + .iter().any(|(_k, v)| **v == regid) |
struct `ConfirmDeviceMessage` is never constructed: libsignal-service/src/provisioning/mod.rs#L108
warning: struct `ConfirmDeviceMessage` is never constructed --> libsignal-service/src/provisioning/mod.rs:108:19 | 108 | pub(crate) struct ConfirmDeviceMessage { | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
direct implementation of `ToString`: libsignal-service/src/configuration.rs#L99
warning: direct implementation of `ToString` --> libsignal-service/src/configuration.rs:99:1 | 99 | / impl ToString for SignalServers { 100 | | fn to_string(&self) -> String { 101 | | match self { 102 | | Self::Staging => "staging", ... | 106 | | } 107 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the function `message_decrypt_prekey` doesn't need a mutable reference: libsignal-service/src/cipher.rs#L185
warning: the function `message_decrypt_prekey` doesn't need a mutable reference --> libsignal-service/src/cipher.rs:185:21 | 185 | &mut self.protocol_store.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: libsignal-service/src/account_manager.rs#L879
warning: this expression creates a reference which is immediately dereferenced by the compiler --> libsignal-service/src/account_manager.rs:879:35 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^ help: change this to: `aci.private_key()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: libsignal-service/src/account_manager.rs#L879
warning: question mark operator is useless here --> libsignal-service/src/account_manager.rs:879:5 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `crate::decrypt_device_name(&aci.private_key(), &name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
called `is_none()` after searching an `Iterator` with `find`: libsignal-service/src/account_manager.rs#L746
warning: called `is_none()` after searching an `Iterator` with `find` --> libsignal-service/src/account_manager.rs:746:24 | 746 | if pni_registration_ids | ________________________^ 747 | | .iter() 748 | | .find(|(_k, v)| **v == regid) 749 | | .is_none() | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some = note: `#[warn(clippy::search_is_some)]` on by default help: consider using | 746 ~ if !pni_registration_ids 747 + .iter().any(|(_k, v)| **v == regid) |
struct `ConfirmDeviceMessage` is never constructed: libsignal-service/src/provisioning/mod.rs#L108
warning: struct `ConfirmDeviceMessage` is never constructed --> libsignal-service/src/provisioning/mod.rs:108:19 | 108 | pub(crate) struct ConfirmDeviceMessage { | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
bound is defined in more than one place: libsignal-service-hyper/src/websocket.rs#L88
warning: bound is defined in more than one place --> libsignal-service-hyper/src/websocket.rs:88:18 | 88 | async fn process<S: Stream>( | ^ ... 94 | S: Stream<Item = Result<Message, TungsteniteError>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: libsignal-service-hyper/src/websocket.rs#L88
warning: bound is defined in more than one place --> libsignal-service-hyper/src/websocket.rs:88:18 | 88 | async fn process<S: Stream>( | ^ ... 93 | S: Unpin, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
direct implementation of `ToString`: libsignal-service/src/configuration.rs#L99
warning: direct implementation of `ToString` --> libsignal-service/src/configuration.rs:99:1 | 99 | / impl ToString for SignalServers { 100 | | fn to_string(&self) -> String { 101 | | match self { 102 | | Self::Staging => "staging", ... | 106 | | } 107 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the function `message_decrypt_prekey` doesn't need a mutable reference: libsignal-service/src/cipher.rs#L185
warning: the function `message_decrypt_prekey` doesn't need a mutable reference --> libsignal-service/src/cipher.rs:185:21 | 185 | &mut self.protocol_store.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: libsignal-service/src/account_manager.rs#L879
warning: this expression creates a reference which is immediately dereferenced by the compiler --> libsignal-service/src/account_manager.rs:879:35 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^ help: change this to: `aci.private_key()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: libsignal-service/src/account_manager.rs#L879
warning: question mark operator is useless here --> libsignal-service/src/account_manager.rs:879:5 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `crate::decrypt_device_name(&aci.private_key(), &name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
called `is_none()` after searching an `Iterator` with `find`: libsignal-service/src/account_manager.rs#L746
warning: called `is_none()` after searching an `Iterator` with `find` --> libsignal-service/src/account_manager.rs:746:24 | 746 | if pni_registration_ids | ________________________^ 747 | | .iter() 748 | | .find(|(_k, v)| **v == regid) 749 | | .is_none() | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some = note: `#[warn(clippy::search_is_some)]` on by default help: consider using | 746 ~ if !pni_registration_ids 747 + .iter().any(|(_k, v)| **v == regid) |
struct `ConfirmDeviceMessage` is never constructed: libsignal-service/src/provisioning/mod.rs#L108
warning: struct `ConfirmDeviceMessage` is never constructed --> libsignal-service/src/provisioning/mod.rs:108:19 | 108 | pub(crate) struct ConfirmDeviceMessage { | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
bound is defined in more than one place: libsignal-service-hyper/src/websocket.rs#L88
warning: bound is defined in more than one place --> libsignal-service-hyper/src/websocket.rs:88:18 | 88 | async fn process<S: Stream>( | ^ ... 94 | S: Stream<Item = Result<Message, TungsteniteError>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: libsignal-service-hyper/src/websocket.rs#L88
warning: bound is defined in more than one place --> libsignal-service-hyper/src/websocket.rs:88:18 | 88 | async fn process<S: Stream>( | ^ ... 93 | S: Unpin, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
direct implementation of `ToString`: libsignal-service/src/configuration.rs#L99
warning: direct implementation of `ToString` --> libsignal-service/src/configuration.rs:99:1 | 99 | / impl ToString for SignalServers { 100 | | fn to_string(&self) -> String { 101 | | match self { 102 | | Self::Staging => "staging", ... | 106 | | } 107 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the function `message_decrypt_prekey` doesn't need a mutable reference: libsignal-service/src/cipher.rs#L185
warning: the function `message_decrypt_prekey` doesn't need a mutable reference --> libsignal-service/src/cipher.rs:185:21 | 185 | &mut self.protocol_store.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: libsignal-service/src/account_manager.rs#L879
warning: this expression creates a reference which is immediately dereferenced by the compiler --> libsignal-service/src/account_manager.rs:879:35 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^ help: change this to: `aci.private_key()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: libsignal-service/src/account_manager.rs#L879
warning: question mark operator is useless here --> libsignal-service/src/account_manager.rs:879:5 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `crate::decrypt_device_name(&aci.private_key(), &name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
called `is_none()` after searching an `Iterator` with `find`: libsignal-service/src/account_manager.rs#L746
warning: called `is_none()` after searching an `Iterator` with `find` --> libsignal-service/src/account_manager.rs:746:24 | 746 | if pni_registration_ids | ________________________^ 747 | | .iter() 748 | | .find(|(_k, v)| **v == regid) 749 | | .is_none() | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some = note: `#[warn(clippy::search_is_some)]` on by default help: consider using | 746 ~ if !pni_registration_ids 747 + .iter().any(|(_k, v)| **v == regid) |
struct `ConfirmDeviceMessage` is never constructed: libsignal-service/src/provisioning/mod.rs#L108
warning: struct `ConfirmDeviceMessage` is never constructed --> libsignal-service/src/provisioning/mod.rs:108:19 | 108 | pub(crate) struct ConfirmDeviceMessage { | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
bound is defined in more than one place: libsignal-service-actix/src/websocket.rs#L69
warning: bound is defined in more than one place --> libsignal-service-actix/src/websocket.rs:69:18 | 69 | async fn process<S: Stream>( | ^ ... 75 | S: Stream<Item = Result<Frame, WsProtocolError>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
bound is defined in more than one place: libsignal-service-actix/src/websocket.rs#L69
warning: bound is defined in more than one place --> libsignal-service-actix/src/websocket.rs:69:18 | 69 | async fn process<S: Stream>( | ^ ... 74 | S: Unpin, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
direct implementation of `ToString`: libsignal-service/src/configuration.rs#L99
warning: direct implementation of `ToString` --> libsignal-service/src/configuration.rs:99:1 | 99 | / impl ToString for SignalServers { 100 | | fn to_string(&self) -> String { 101 | | match self { 102 | | Self::Staging => "staging", ... | 106 | | } 107 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
the function `message_decrypt_prekey` doesn't need a mutable reference: libsignal-service/src/cipher.rs#L185
warning: the function `message_decrypt_prekey` doesn't need a mutable reference --> libsignal-service/src/cipher.rs:185:21 | 185 | &mut self.protocol_store.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: libsignal-service/src/account_manager.rs#L879
warning: this expression creates a reference which is immediately dereferenced by the compiler --> libsignal-service/src/account_manager.rs:879:35 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^ help: change this to: `aci.private_key()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: libsignal-service/src/account_manager.rs#L879
warning: question mark operator is useless here --> libsignal-service/src/account_manager.rs:879:5 | 879 | Ok(crate::decrypt_device_name(&aci.private_key(), &name)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `crate::decrypt_device_name(&aci.private_key(), &name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
called `is_none()` after searching an `Iterator` with `find`: libsignal-service/src/account_manager.rs#L746
warning: called `is_none()` after searching an `Iterator` with `find` --> libsignal-service/src/account_manager.rs:746:24 | 746 | if pni_registration_ids | ________________________^ 747 | | .iter() 748 | | .find(|(_k, v)| **v == regid) 749 | | .is_none() | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some = note: `#[warn(clippy::search_is_some)]` on by default help: consider using | 746 ~ if !pni_registration_ids 747 + .iter().any(|(_k, v)| **v == regid) |
struct `ConfirmDeviceMessage` is never constructed: libsignal-service/src/provisioning/mod.rs#L108
warning: struct `ConfirmDeviceMessage` is never constructed --> libsignal-service/src/provisioning/mod.rs:108:19 | 108 | pub(crate) struct ConfirmDeviceMessage { | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default