fix: switch rustls backend back to ring #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rultls switched their crypto backend to aws-lc, which unfortunately supports fewer platforms. For now, we switch the backend back to ring. Also disable tls1.2 (signal servers supports tls1.3), and tokio native certs that are not used.
gferon
approved these changes
Aug 12, 2024
|
LGTM -- this makes Whisperfish compile locally in Sailfish SDK for armv7hl again. |
|
@rubdos also LGTM'd this -- merging as discussed over at Signal. |
|
ntninja wrote a good comment about resolving the remaining issues in getting aws-lc working in sfdk: https://gitlab.com/whisperfish/whisperfish/-/merge_requests/593#note_2086577607 I'll drop the link here in case we need to make it work in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rultls switched their crypto backend to aws-lc, which unfortunately supports fewer platforms. For now, we switch the backend back to ring.
Also disable tls1.2 (signal servers supports tls1.3), and tokio native certs that are not used.