Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create secure context to use cert client auth and validate server ca #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymahlaoui
Copy link

This mod is for using cert client auth to syslog server and also validate the server cet

@DABH
Copy link
Contributor

DABH commented Jan 4, 2024

I think this would break things for users using secureProtocol, which doesn't seem ideal. Do you have any thoughts on that? Should we support both secureProtocol and secureContext fields? In any case, if we wanted to accept this PR, it would be very helpful to add a test and ideally some documentation, too, so people know what this is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants