WIP: twig node migration #1102
Draft
WIP: twig node migration #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Thomson <[email protected]> Documented by wintercms/docs#182
Co-authored-by: interworks-morr <intentionally left blank> Fixes #1092
Adds support for all the Arr::*() helpers through array_*() functions in Twig
Also improved support for datetime values using periods as a separator.
… config Commit 609ad74 introduced support for the "no-progress" option. A "%noProgress%" placeholder has been added into the Mix compilation file which is replaced by a boolean depending on if this option is used or not. However, while we properly handled the "mix:compile" command, we forgot to add this to the "mix:watch" command too. This should fix this.
The "encryption" option is redundant as encryption is always forced for port 465 & encryption will be automatically enabled using STARTTLS for other ports (e.g. 25 and 587) if available from the mail server CAPABILITIES by the underlying Laravel & Symfony libaries.
Co-authored-by: Luke Towers <[email protected]> Fixes #1036.
Removed in 9c1d2a8, but the mail driver plugins only provide the config values when using the backend mail settings page.
Co-authored-by: Luke Towers <[email protected]>
This PR adds support for enabling the Mix manifest, see Laravel Mix Asset Versioning (https://github.com/orgs/wintercms/discussions/476#discussioncomment-10088281). The change here uses the existing options method provided by Mix to override our default behaviour. // Enable default manifest mix.options({ manifest: true, }); // Disable manifiest (default behaviour) mix.options({ manifest: false, }); // Set a custom path for the manifest mix.options({ manifest: 'assets/manifest.json', });
This PR adds a new `BundleManager` class which is responsible for managing the different "asset bundles" available in Winter. Bundles will automatically be offered by the `vite:create` & `mix:create` scaffolding commands as option flags.
This allows us to:
- Have a single entity responsible for managing versions
- Allow the user to configure their own bundles / overwrite the existing bundles if desired
- Manage the update process better by reducing magic numbers in the system
I've also cleaned up some of the install logic and added some user feedback similar to `create:plugin` when running `{$compiler}:create`.
In addition to the above, this PR removes the majority of the fixtures for Mix/Vite configs and now lets subscribers modify the base config on the fly.
```php
\System\Classes\Asset\BundleManager::instance()->registerCallback(function ($manager) {
// Register a bundle (using a compiler as a key and having an array as a value means that the array
// will be squashed into the bundle when that compiler is being called, else the array will be discarded):
$manager->registerBundle('jaxjs', [
'jaxjs' => 'v1.0.0',
'mix' => [
'mix-jaxjs-adapter' => 'v1.2.0'
],
'vite' => [
'vite-jaxjs-adapter' => 'v1.6.0'
],
]);
// Register a setup handler (is executed on install to allow for bundles to generate their own config
// files / prep the plugin)
$manager->registerSetupHandler('jaxjs', function (string $packagePath, string $packageType) {
$this->writeFile(
$packagePath . '/jax.js',
File::get(__DIR__ . '/../fixtures/jax.js')
);
});
// Register a scaffold handler (is executed during stub/config generation), `contentType`
// can be: vite, mix, js, css.
$manager->registerScaffoldHandler('jaxjs', function (string $contents, string $contentType) {
return match ($contentType) {
'mix' => $contents . PHP_EOL . <<<JAVASCRIPT
console.log('jaxjs installed');
JAVASCRIPT,
'vite' => $contents . PHP_EOL . '// example',
'css' => $content . PHP_EOL . $this->getFixture('css/jaxjs.css.fixture'),
'js' => $this->getFixture('js/jaxjs.fixture')
default => $contents
};
});
]);
```
Once the configs have been set, either via a config file, or from config calls in a plugin, the following can be ran in the CLI:
```bash
./artisan vite:create Acme.Plugin --jaxjs
# Or
./artisan mix:create Acme.Plugin --jaxjs
```
Plugins can call these methods to register handlers to modify either stub or config generation, or do additional tasks when the `{$compiler}:create` command is ran.
> **NOTE**: `setupHandlers` & `scaffoldHandlers` are executed within the context of `AssetCreate` this means they have access to the internal properties of the class such as `assetType` (`mix` or `vite`) and have access to methods such as `writeFile()` & `getFixture()`.
The Storm version of Relation will be converted to an interface when Laravel-style relations is merged, but it makes sense to change these now anyway as the static method is defined in Laravel and was not overwritten by the Storm wrapper.
This fix allows nested objects within the request data to be correctly converted to nested form data when sending the request. Previously, if the data option in a Request contained nested objects or arrays within the data, these were being incorrectly converted to [Array array] or [Object object], as the FormData object would simply convert them to strings. With this fix, we traverse the data structure and ensure that they are given the right key in order to keep the shape of the data in the POST data.
Console command to purge all entries in resized storage folder.
No longer used or useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Twig 3.9.0, Nodes using "echo" or "print" are deprecated and should use "yield":
ref. twigphp/Twig@0990f81