Cleanup after model is deleted #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lex0r can you test if this resolves the issue? |
|
How does this handle the parent record being soft deleted? |
|
It doesn't... I'll apply conditionally in afterModelDelete() then. |
|
@LukeTowers that should address the softdelete concern. |
|
Is there a way that we can support deleting the data when a softdeleted record is permanently deleted? |
Good point. |
LukeTowers
reviewed
Apr 30, 2024
LukeTowers
approved these changes
Apr 30, 2024
|
@lex0r it would really be appreciated if you could test this in your environment so we can get this merged. Thanks! |
|
Hi @mjauvin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12