POC: Start using Codex #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought the TextInput would be an easy component to start with. I was wrong, but hey, at least this mostly works. I also left some TODOs in the code as a treat. Bug: T369505
Use them as CSS variables, so they’ll automatically be updated when MediaWiki ships a new Codex version without having to rebuild the app (and they can depend on the skin too). To avoid including all the design tokens in the build anyway (Vite doesn’t really support excluding CSS imports yet, see vitejs/vite#18037), we have to make sure to not import the tokens anywhere in the app (i.e. neither in NewLexemeForm.vue nor in App.vue) – only directly in the index.html (dev entry point). Bug: T369505
| @@ -3,6 +3,7 @@ import AnonymousEditWarning from '@/components/AnonymousEditWarning.vue'; | |||
| import NewLexemeForm from '@/components/NewLexemeForm.vue'; | |||
| import SearchExisting from '@/components/SearchExisting.vue'; | |||
| import '@wmde/wikit-vue-components/dist/wikit-vue-components.css'; | |||
| import '@wikimedia/codex/dist/codex.style.css'; | |||
There was a problem hiding this comment.
Move this to index.html, we don’t want the codex CSS to be included in our build!
|
Superseded by #746, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the
TextInputwould be an easy component to start with. I was wrong, but hey, at least this mostly works. I also left some TODOs in the code as a treat.Bug: T369505