Externalizing all parameters through .env file #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wmnnd Is there any plan to merge this. BTW, thanks for your good work. |
|
Thanks, this is a great improvement! Why it isn't merged so long time? |
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wmnnd the idea behind this PR is that you don't need to tweak the script file to configure anything such as domains, emails, etc. Just create a .env file and add the required variables and the script will pick it up - for both LetsEncrypt and Nginx. If you don't provide the env file, it functions as before with defaults. Readme docs have also been updated.