Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message struct #114

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add error message struct #114

merged 1 commit into from
Apr 23, 2024

Conversation

wooorm
Copy link
Owner

@wooorm wooorm commented Apr 22, 2024

This is like what wooorm/mdxjs-rs#43 achieves but is implemented in the markdown parser, so that all errors can be the same struct, instead of only some.

It also follows vfile-message, the JavaScript counterpart, so that errors are similar in JavaScript and Rust.

Closes GH-108.
Closes: wooorm/mdxjs-rs#42.
Closes: wooorm/mdxjs-rs#43.

/cc @kdy1: this stores clean positional info on errors, is this what you want?

@kdy1
Copy link
Collaborator

kdy1 commented Apr 23, 2024

Yeap, and it looks far better than my PR. Huge thanks!

@wooorm wooorm merged commit 3dc7f1a into main Apr 23, 2024
4 checks passed
@wooorm wooorm deleted the message branch April 23, 2024 08:11
@wooorm wooorm mentioned this pull request Sep 19, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants