feat: register_meta. Closes #1348. #1600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilwis
requested changes
Aug 19, 2024
E update hết rồi nhé, giờ e chuyển qua làm block binding nếu cần update gì bên này thì e update tiếp |
rilwis
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Hiện tại 1 số field như post, taxonomy, user và taxonomy_advanced (khi ko multiple) thì đều trả về giá trị định dạng integer e nhé. E format lại giá trị trả về nhé.
Trong commit mới, a có update lại hàm register_meta vì tham số đầu tiên của nó phải là object_type, và nhận giá trị post, term, user, ... thôi. Tham số object_subtype mới nhận giá trị là post type.
A có 1 số comment nhỏ khác, e xem nhé.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register meta and unit test. Closes #1348.