Adding username input validation userInfohandler #4862 #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public String getTenantAwareUsername(String username) { | ||
|
|
||
| String tenantDomain = getTenantDomainFromContext(); | ||
| if (tenantDomain.equalsIgnoreCase(username.substring(username.lastIndexOf('@') + 1))) { |
There was a problem hiding this comment.
What will happen if email username is enabled and email domain and tenant domain are same?
Thumimku
force-pushed
the
UserInfoImpl
branch
from
bc61b8c
to
6c4f2cd
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6195873396
madurangasiriwardena
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Issue: wso2/product-is#16357
UserInfoHandlerImpl implements UserInforHandler to modify following methods which uses tenant-wise username type.