Include the page layout in the branding page #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <BrandingCore /> | ||
| <BrandingPreferenceProvider> | ||
| <PageLayout | ||
| pageTitle="Branding" |
There was a problem hiding this comment.
Suggested change
| pageTitle="Branding" | |
| pageTitle={ t("extensions:develop.branding.pageHeader.title") } |
There was a problem hiding this comment.
Addressed with 3ee321b
Comment on lines
606
to
610
| content={ | ||
| ( | ||
| <> | ||
| { t("extensions:develop.branding.publishToggle.hint") } | ||
| </> |
There was a problem hiding this comment.
Suggested change
| content={ | |
| ( | |
| <> | |
| { t("extensions:develop.branding.publishToggle.hint") } | |
| </> | |
| content={ t("extensions:develop.branding.publishToggle.hint") } |
There was a problem hiding this comment.
Added with 3ee321b
Comment on lines
618
to
624
| showSubOrgBrandingUpdateAlert | ||
| ? ( | ||
| <Alert onClose={ () => setShowSubOrgBrandingUpdateAlert(false) } severity="warning"> | ||
| { t("extensions:develop.branding.notifications.update.successWaitingAlert.description", | ||
| { tenant: tenantDomain }) } | ||
| </Alert> | ||
| ) : null |
There was a problem hiding this comment.
Suggested change
| showSubOrgBrandingUpdateAlert | |
| ? ( | |
| <Alert onClose={ () => setShowSubOrgBrandingUpdateAlert(false) } severity="warning"> | |
| { t("extensions:develop.branding.notifications.update.successWaitingAlert.description", | |
| { tenant: tenantDomain }) } | |
| </Alert> | |
| ) : null | |
| showSubOrgBrandingUpdateAlert | |
| && ( | |
| <Alert onClose={ () => setShowSubOrgBrandingUpdateAlert(false) } severity="warning"> | |
| { t("extensions:develop.branding.notifications.update.successWaitingAlert.description", | |
| { tenant: tenantDomain }) } | |
| </Alert> | |
| ) |
There was a problem hiding this comment.
Added with 3ee321b
Comment on lines
627
to
633
| showSubOrgBrandingDeleteAlert | ||
| ? ( | ||
| <Alert onClose={ () => setShowSubOrgBrandingDeleteAlert(false) } severity="warning"> | ||
| { t("extensions:develop.branding.notifications.delete.successWaitingAlert.description", | ||
| { tenant: tenantDomain }) } | ||
| </Alert> | ||
| ) : null |
There was a problem hiding this comment.
Suggested change
| showSubOrgBrandingDeleteAlert | |
| ? ( | |
| <Alert onClose={ () => setShowSubOrgBrandingDeleteAlert(false) } severity="warning"> | |
| { t("extensions:develop.branding.notifications.delete.successWaitingAlert.description", | |
| { tenant: tenantDomain }) } | |
| </Alert> | |
| ) : null | |
| showSubOrgBrandingDeleteAlert | |
| && ( | |
| <Alert onClose={ () => setShowSubOrgBrandingDeleteAlert(false) } severity="warning"> | |
| { t("extensions:develop.branding.notifications.delete.successWaitingAlert.description", | |
| { tenant: tenantDomain }) } | |
| </Alert> | |
| ) |
There was a problem hiding this comment.
Added with 3ee321b
brionmario
previously approved these changes
Apr 1, 2024
chamathns
force-pushed
the
branding-refactor-3
branch
from
f07290e
to
1e17e68
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improvement for #5868
Related Issues
Related PRs
#1or (None)Checklist
Security checks