Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Authentication Type label name to Authentication Scheme in Action UI #6845

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

ashanthamara
Copy link
Contributor

Purpose

$subject

Related Issues

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@@ -113,10 +113,10 @@ export const actions: actionsNS = {
create: "Once added, these secrets will not be displayed. You will only be able to reset them.",
update: "Once updated, these secrets will not be displayed. You will only be able to reset them again."
},
label: "Authentication Type",
placeholder: "Select Authentication Type",
label: "Authentication Scheme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Authentication Method" instead? That's more comprehensive than "Scheme" IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by @johannnallathamby and @malithie as this is the term that is used in other similar places

@ashanthamara ashanthamara merged commit 474a766 into wso2:master Aug 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants