Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "orgDiscovery" Param to "login_hint" #6912

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Sep 23, 2024

Purpose

  • Rename orgDiscovery param to login_hint in order to utilize a standard dialect.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@dhaura dhaura added the trigger-pr-builder Manually trigger PR builder workflow label Sep 23, 2024
@dhaura dhaura changed the title Rename "orgDiscovery" param to "login_hint" Rename "orgDiscovery" Param to "login_hint" Sep 23, 2024
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (825f099) to head (1789e68).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6912   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      204      206    +2     
=======================================
  Hits          283      283           
+ Misses        607      587   -20     
- Partials        0       20   +20     
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@dhaura dhaura merged commit 2d387f7 into wso2:master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trigger-pr-builder Manually trigger PR builder workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants