Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx (fix): Avoid concurrent modification of RxVar subscribers #3113

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 6, 2023

@xerial xerial enabled auto-merge (squash) August 6, 2023 21:08
@github-actions github-actions bot added the bug label Aug 6, 2023
@xerial xerial changed the title okhttp (fix): Avoid concurrent modification" -m "Fixes #3109 okhttp (fix): Avoid concurrent modification Aug 6, 2023
@xerial xerial changed the title okhttp (fix): Avoid concurrent modification okhttp (fix): Avoid concurrent modification in AsyncClient Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #3113 (8d727da) into master (9c0a70a) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
- Coverage   82.85%   82.84%   -0.01%     
==========================================
  Files         350      350              
  Lines       14718    14723       +5     
  Branches     2420     2447      +27     
==========================================
+ Hits        12195    12198       +3     
- Misses       2523     2525       +2     
Files Changed Coverage Δ
...ala/wvlet/airframe/http/okhttp/OkHttpChannel.scala 91.66% <100.00%> (ø)
...ain/scala/wvlet/airframe/http/okhttp/package.scala 72.00% <100.00%> (ø)
...me-rx/src/main/scala/wvlet/airframe/rx/RxVar.scala 86.66% <100.00%> (+2.66%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c983b...8d727da. Read the comment docs.

@xerial xerial disabled auto-merge August 6, 2023 21:16
@xerial xerial changed the title okhttp (fix): Avoid concurrent modification in AsyncClient rx (fix): Avoid concurrent modification of RxVar subscribers Aug 6, 2023
@xerial xerial enabled auto-merge (squash) August 6, 2023 21:40
@xerial xerial merged commit 92544f1 into master Aug 6, 2023
17 checks passed
@xerial xerial deleted the okhttp-async-fix branch August 6, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OkHttp Dispatcher: java.util.ConcurrentModificationException: mutation occurred during iteration
1 participant