-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surface: Simplify extractSymbol - avoid .tree to make library working with Scala 3.4.2 #3533
base: main
Are you sure you want to change the base?
Conversation
The airframe tests passed locally, but some tests for other modules fail on CI. I will check what is going on. |
The issue is with:
Compiler crashes with:
My fix causes bad representation of |
fb755f9
to
b9928d5
Compare
I am afraid I am unable to fix this. I was missing one dealias, once I have added it, types both with and without the fix seem correct, without the fix the type is represented as It works fine in my "light" fork without the method accessors. Unless this is fixed, expect trouble once users of the library port to 3.4.2. No fix logs:
With the fix:
Note |
As a preliminary work, I've added a CI for Scala 3.4.2 to reproduce this issue #3590. As path-dependent type support is a bit complicated, I will revisit the current implementation later based on this PR. Thanks for reporting and trying to fix the issue. |
Followup to #3521
The method
extractSymbol
used to dealias inner types for both opaque types and type aliases does not work when the library is used from Scala 3.4.2 application. The reason is infamous.tree
method again, which is known and documented to be unreliable.I am not sure why it was used, the code seems simpler without it, but maybe I am missing something. After the simplification all tests still pass.