Support of multiple Python versions in integration tests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Burmak
force-pushed
the
22.04
branch
2 times, most recently
from
ad64ba3
to
cf11773
Compare
Alex-Burmak
changed the title
Alex-Burmak
force-pushed
the
22.04
branch
13 times, most recently
from
05d7b0c
to
e601b3b
Compare
Alex-Burmak
force-pushed
the
22.04
branch
2 times, most recently
from
1fdcb29
to
3710a3a
Compare
Alex-Burmak
force-pushed
the
22.04
branch
3 times, most recently
from
53913e5
to
914e7e4
Compare
aalexfvk
reviewed
Sep 5, 2023
| @@ -55,4 +55,4 @@ def make_tar_header(name: str, file_path: Path) -> bytes: | |||
| tarinfo = tarfile.TarInfo(name) | |||
| stat = file_path.stat() | |||
| tarinfo.mtime, tarinfo.size = int(stat.st_mtime), stat.st_size | |||
| return tarinfo.tobuf() | |||
| return tarinfo.tobuf(format=tarfile.GNU_FORMAT) | |||
There was a problem hiding this comment.
Pass the format explicitly because the default was changed since Python 3.8
Changed in version 3.8: The default format for new archives was changed to PAX_FORMAT from GNU_FORMAT.
aalexfvk
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.