Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take a lock on wider scope in delete and purge cmd. #68

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Take a lock on wider scope in delete and purge cmd. #68

merged 3 commits into from
Sep 12, 2023

Conversation

MikhailBurdukov
Copy link
Contributor

  • Moved lock acquisition at the begging of delete and purge command.
  • Made it so that the non-light metadata is loaded once for all backups .

Resolves #51.

@MikhailBurdukov MikhailBurdukov marked this pull request as ready for review September 11, 2023 17:04
aalexfvk
aalexfvk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@aalexfvk aalexfvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay to me, but let someone else look at it.

@MikhailBurdukov MikhailBurdukov merged commit a977419 into main Sep 12, 2023
11 checks passed
@MikhailBurdukov MikhailBurdukov deleted the MDB-24910-take_lock_on_wider_scope_delete branch September 12, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MedvedewEM MedvedewEM MedvedewEM approved these changes

@aalexfvk aalexfvk aalexfvk approved these changes

@Alex-Burmak Alex-Burmak Awaiting requested review from Alex-Burmak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take a lock on collecting backups info for deduplication while deleting with purge-partial parameter
3 participants
@MikhailBurdukov @MedvedewEM @aalexfvk