Loguru for logging. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we switch to the |
MikhailBurdukov
requested review from
aalexfvk and
Alex-Burmak
and removed request for
aalexfvk
aalexfvk
reviewed
Sep 26, 2023
| "level": "DEBUG", | ||
| }, | ||
| }, | ||
| "loguru": { |
There was a problem hiding this comment.
I'd propose to change the config structure.
I propose to move format definition in a separate key instead of function _handler_configuration
Like so:
"loguru" : {
"formats": {
"ch-backup": "{time:YYYY-MM-DD H:m:s,SSS} {process.name:11} {process.id:5} [{level:8}] {extra[logger_name]}: {message}",
},
"handlers": {
"ch-backup": {
"sink": "/var/log/ch-backup/ch-backup.log",
"level": "DEBUG",
"format": "ch-backup"
# "enqueue": True # don't define this but set all handlers in code as enqueued without option
}
#...
}
#...
}
ch_backup/config.py
Outdated
| "urllib3.connectionpool", "/var/log/ch-backup/boto.log", "DEBUG" | ||
| ), | ||
| ], | ||
| "activation": [ |
There was a problem hiding this comment.
Let's remove this from config. It may be confusing what this option for.
aalexfvk
reviewed
Sep 26, 2023
ch_backup/logging.py
Outdated
| frame = frame.f_back | ||
| depth += 1 | ||
|
|
||
| try: |
There was a problem hiding this comment.
Let's remove this and put bind(logger_name=record.name) to pass original logger name to handlers
aalexfvk
reviewed
Sep 26, 2023
ch_backup/clickhouse/disks.py
Outdated
| @@ -184,7 +184,7 @@ def _copy_dir(from_disk: str, from_path: str, to_disk: str, to_path: str) -> Non | |||
|
|
|||
|
|
|||
| def _exec(command: str, common_args: List[str], command_args: List[str]) -> List[str]: | |||
| logger = logging.getLogger("clickhouse-disks") | |||
| logger = ch_logging.getLogger("clickhouse-disks") | |||
There was a problem hiding this comment.
Rename ch_logging to logging ?
ch_backup/config.py
Outdated
|
|
||
|
|
||
| def _as_seconds(t: str) -> int: | ||
| return int(parse_timespan(t)) | ||
|
|
||
|
|
||
| def _handler_configuration(name: str, sink: str, level: str) -> dict: |
In this PR not. |
aalexfvk
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
loggingmodule tologuruto provide process-safe logging.