Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two formatting issues on Contributing page #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roryokane
Copy link

@roryokane roryokane commented Oct 8, 2023

https://yargs.js.org/contributing/ had two visible issues:

  • There was a space before the comma in “Create a new issue , or comment on an existing issue”. This was due to the practice of writing all a elements with inner spaces. I removed all such inner spaces to avoid this problem in the future.
  • There was an unnecessary comma after a sentence: “write code. ,”

I also deleted some unnecessary blank lines at the bottom.

I did not try rebuilding the repo with Jekyll; I just edited this one file in the web editor. I don’t see any other source files for the Contributing page, though, so I think this should work.

https://yargs.js.org/contributing/ had two visible issues:

- There was a space before the comma in “Create a new issue , or comment on an existing issue”. This was due to the practice of writing all `a` elements with inner spaces. I removed all such inner spaces to avoid this problem in the future.
- There was an unnecessary comma after a sentence: “write code. ,”

I also deeleted some unnecessary blank lines at the bottom.
Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am vague on the build details, but visually the changes look fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants