Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Extra Args #42

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fixing Extra Args #42

merged 2 commits into from
Jul 24, 2023

Conversation

yhakbar
Copy link
Owner

@yhakbar yhakbar commented Jul 24, 2023

Summary

Was running into issues with how extra_args was being pulled in on the CLI before making this adjustment.

This makes it so that all arguments being passed to prog are collected into an intermediate vector before being printed with -x or being run.

Changes

  • Using a secondary vector to collect all the args before adding them to the command builder
  • Updating test now that we're not adding single quotes to the cmd value

@yhakbar yhakbar merged commit 152b4db into main Jul 24, 2023
2 checks passed
@yhakbar yhakbar deleted the bugfix/fixing_extra_args branch July 24, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant