-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Layout: Add repre_type as json element #104
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -99,13 +96,15 @@ def process(self, instance): | |||
"instance_name": cmds.getAttr( | |||
"{}.namespace".format(container)), | |||
"representation": str(representation_id), | |||
"version": str(version_id) | |||
"version": str(version_id), | |||
"extension": representation["name"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the representation name does not have to be the extension. A representation may also have representation["ext"]
, right @iLLiCiTiT ? Not sure if that is ALWAYS set though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moonyuet the error is not because it is not supported, but because you don't fill it (not your, but who implemented repre creation). You can fill "ext"
with extension and "name"
with whatever you want -> name can be "algebraic_theorem"
, but ext would be "txt"
.
NOTE: I don't know full context, let me know If I'm off.
BTW I see line above there is stored version id, why is not stored representation id here too? It is not yet known? How is the version id known in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked and you're working with existing representation entity. So the ext is in representation["context"]["ext"]
.
NOTE: And also found out that it takes product type from representation context too, which is not really good idea. It should fetch product entity and use productType
from it (not related to this PR).
Co-authored-by: Roy Nieterau <[email protected]>
Changelog Description
This PR is to add extension of the loaded asset as part of the elements in the json published from extract layout.
Resolve #100
Additional info
The adjustment of the codes does not mean the transformation data of alembic has been fixed (The related code still hasn't been touched)
Testing notes: