Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Look publish validation reports #20

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 12, 2024

Description

Improve look validation reports.

Changes

Better Look Data Contents validation report

Before:

image

After:

image

Better Look Sets validation report

Before:

image

After:

image

Fix header title odd smaller cbId text.

Before:

image

After:

image

Testing notes:

  1. Break cbId attributes on loaded models
  2. Run look publish
  3. Validation reports should be nice.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jul 12, 2024
@BigRoy BigRoy self-assigned this Jul 29, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did different tests with missing cbIDs and initialShadingGroup and All seems fine and working well.

Looks good to me...

Screenshot 2024-08-02 154217

@BigRoy BigRoy merged commit cd867d5 into ynput:develop Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants