Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Maya USD Extraction #59

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Improve Maya USD Extraction #59

merged 3 commits into from
Jul 31, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 30, 2024 •
edited
Loading

Changelog Description

Add more options to the Maya USD Extractor:

  • Expose USD extractor for model and pointcache family
  • Do not export shaders by default
  • Allow to Enable/disable animation data
  • Update defaults to be more sensible like maya's defaults
  • Allow using export roots to exclude parents in export
  • Allow to export in worldspace when parents are not included
  • Ignore constraints to avoid constraints breaking merge transform/shape behavior

Additional info

Separated from #2

Testing notes:

  1. Maya USD extraction should work
  2. When enabled, model extraction with Extract usd enabled should work
  3. When enabled, pointcache extraction with Extract usd enabled should work
  4. When enabled, animation extraction with Extract usd enabled should work
  5. The Maya USD Creator has a Create Asset Hierarchy checkbox (on Create tab) which should do what it describes:

image

@BigRoy
Improve Maya USD Extraction
4d9bffe 
- Expose USD extract for model and pointcache family
- Do not export shaders by default
- Allow to Enable/disable animation data
- Update defaults to be more sensible like maya's defaults
- Allow using export roots to exclude parents in export
- Allow to export in worldspace when parents are not included
- Ignore constraints to avoid constraints breaking merge transform/shape behavior
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jul 30, 2024
@BigRoy BigRoy self-assigned this Jul 30, 2024
@BigRoy BigRoy mentioned this pull request Jul 30, 2024
Closed
moonyuet
moonyuet reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with animation product type
looks good and animation publish. And I can load back the animation data as expected.
Will test the model/pointcache product type later

moonyuet
moonyuet approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added screenshot regarding to the previous comment
image

Tested in Model and Pointcache product type, published and loaded without any error.
also tested with the maya usd product type publish and load. looks good.
Animation, pointcache and usd can export animation data as expected when export animation data being turned on.

image

@BigRoy BigRoy merged commit f3fa781 into ynput:develop Jul 31, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/maya_usd_export_fixes branch July 31, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@BigRoy BigRoy

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigRoy @moonyuet