Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve applying render resolution and aspect ratio on render settings reset #75

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Aug 22, 2024

Changelog Description

Fix pixel aspect ratio / device aspect ratio getting messed up for Arnold renderer on render settings reset.

Additionally:

  • This now applies the resolution from the task entity, not the folder entity.
  • This now also applies pixel aspect ratio as defined on the entity.

Additional info

This fixes a bug when resetting render resolution for Arnold where on reset the pixel/device aspect ratio would be oddly set with a pixel aspect ratio that is not 1.0.

E.g. left is before, right is after resetting render settings without this PR
image

After this PR the pixel aspect ratio will now adhere to what is specified on the task entity.
This bug was only occurring if the current renderer render settings were reset for was actively Arnold (mtoa) renderer.

Testing notes:

  1. Resetting render settings should work for the different renderers and should set the resolution (and pixel aspect ratio correctly!)
    • Arnold (mtoa)
    • Redshift (should work if Arnold works because it uses same attributes as Arnold)
    • V-Ray (may be good to check because it uses a custom render settings node!)
    • Renderman (should work if Arnold works because it uses same attributes as Arnold)

Note that this is about Set Render Settings or the feature that it automatically does so on creating a render publish instance in the scene (enabled by default).

image

…nold renderer on render settings reset.

Additionally:
- This now applies the resolution from the task entity, not the folder entity.
- This now also applies pixel aspect ratio as defined on the entity.
@BigRoy BigRoy added type: bug Something isn't working type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Aug 22, 2024
@BigRoy BigRoy self-assigned this Aug 22, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for Arnold Rshift and probably for Renderman

but fails with Vray throwing following error msg:

# Error: TypeError: file C:\Users\lbate\AppData\Local\Ynput\AYON\addons\maya_0.2.11-dev.1\ayon_maya\api\lib_rendersettings.py line 113: _set_vray_settings() missing 3 required positional arguments: 'height', 'pixel_aspect', and 'aov_separator'

@BigRoy BigRoy requested a review from LiborBatek August 27, 2024 11:50
@BigRoy
Copy link
Contributor Author

BigRoy commented Aug 27, 2024

but fails with Vray throwing following error msg:

# Error: TypeError: file C:\Users\lbate\AppData\Local\Ynput\AYON\addons\maya_0.2.11-dev.1\ayon_maya\api\lib_rendersettings.py line 113: _set_vray_settings() missing 3 required positional arguments: 'height', 'pixel_aspect', and 'aov_separator'

Sorry about that. Completely my bad! Please try again.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working now even with Vray.

Also tested with overrides on Entity level and Task level and both are working nicely!

I guess we can merge it (saving some time with Renderman...as it should work same as Arnold)

@BigRoy BigRoy merged commit 0e5ca50 into ynput:develop Aug 27, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/AY-6582-maya-reset-render-settings-aspect branch August 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants