Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Multi-shot layout: Add label only if not same as shot name. #94

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 5, 2024

Changelog Description

In recent versions of AYON the "label" is always set by default and matches the "name" whereas previously, "label" defaulted to an empty value. Hence, due to that update, this logic now needed to change to correctly detect whether a customized label was set.

Additional info

Fixes an issue where the shot name in camera sequencer would be shot (shot) where the labels between the brackets matched the shot name, making it look odd.

Testing notes:

  1. Run create multi-shot layout
  2. Have shots with and without customized labels
  3. Only those with customized labels should have that between brackest like {name} ({label})

In recent versions of AYON the "label" is always set by default and matches the "name" whereas previously, "label" defaulted to an empty value. Hence, due to that update, this logic now needed to change to correctly detect whether a customized label was set.
@BigRoy BigRoy added the type: bug Something isn't working label Sep 5, 2024
@BigRoy BigRoy self-assigned this Sep 5, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

before this PR:
Screenshot 2024-09-20 150032

and with this PR:

Screenshot 2024-09-20 150638

@antirotor antirotor merged commit ceb4de1 into ynput:develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants