Skip to content

Commit

Permalink
Cherry pick PR #4047: Add media_support_internal to media_util gn tar…
Browse files Browse the repository at this point in the history
…get (#4053)

Refer to the original PR: youtube/cobalt#4047

It was missing.  It didn't cause any build issues as it's a header file.

Also removed media_is_audio_supported.cc, media_is_supported.cc, and
media_is_video_supported.cc from stub/BUILD.gn. They are not
implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is
internal interface, not exposed to Cobalt) and shouldn't be included in
stub/BUILD.gn.

b/361864042

---------

Co-authored-by: xiaomings <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and xiaomings committed Aug 27, 2024
1 parent bb633ad commit 8ce2738
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions starboard/shared/starboard/media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ static_library("media_util") {
"//starboard/shared/starboard/media/codec_util.h",
"//starboard/shared/starboard/media/key_system_supportability_cache.cc",
"//starboard/shared/starboard/media/key_system_supportability_cache.h",
"//starboard/shared/starboard/media/media_support_internal.h",
"//starboard/shared/starboard/media/media_util.cc",
"//starboard/shared/starboard/media/media_util.h",
"//starboard/shared/starboard/media/mime_supportability_cache.cc",
Expand Down
3 changes: 0 additions & 3 deletions starboard/stub/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,8 @@ static_library("stub_sources") {
"//starboard/shared/stub/media_get_max_buffer_capacity.cc",
"//starboard/shared/stub/media_get_progressive_buffer_budget.cc",
"//starboard/shared/stub/media_get_video_buffer_budget.cc",
"//starboard/shared/stub/media_is_audio_supported.cc",
"//starboard/shared/stub/media_is_buffer_pool_allocate_on_demand.cc",
"//starboard/shared/stub/media_is_buffer_using_memory_pool.cc",
"//starboard/shared/stub/media_is_supported.cc",
"//starboard/shared/stub/media_is_video_supported.cc",
"//starboard/shared/stub/media_set_audio_write_duration.cc",
"//starboard/shared/stub/memory_allocate_aligned_unchecked.cc",
"//starboard/shared/stub/memory_allocate_unchecked.cc",
Expand Down

0 comments on commit 8ce2738

Please sign in to comment.