Fix lint issues in feature branch (#2970)

b/335357085
youtube · Apr 17, 2024 · 4708bf5 · 4708bf5
1 parent e889697
commit 4708bf5
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 37 deletions.
diff --git a/cobalt/layout_tests/web_platform_test_parser.cc b/cobalt/layout_tests/web_platform_test_parser.cc
@@ -119,12 +119,12 @@ std::vector<WebPlatformTestInfo> EnumerateWebPlatformTests(
         &result);
 
     if (!success) {
-      DLOG(ERROR) << "Failed to evaluate precondition: "
-                  << "\"" << precondition << "\"";
+      DLOG(ERROR) << "Failed to evaluate precondition: " << "\"" << precondition
+                  << "\"";
       // Continue to enumerate tests like normal.
     } else if (result != "true") {
-      DLOG(WARNING) << "Skipping Web Platform Tests for "
-                    << "\"" << top_level << "\"";
+      DLOG(WARNING) << "Skipping Web Platform Tests for " << "\"" << top_level
+                    << "\"";
       return std::vector<WebPlatformTestInfo>();
     }
   }

diff --git a/cobalt/network/dial/dial_http_server.h b/cobalt/network/dial/dial_http_server.h
@@ -49,7 +49,7 @@ class NET_EXPORT DialHttpServer
   void Stop();
 
   // HttpServer::Delegate implementation
-  void OnConnect(int /*conn_id*/) override{};
+  void OnConnect(int /*conn_id*/) override {};
   void OnHttpRequest(int conn_id,
                      const net::HttpServerRequestInfo& info) override;
 

diff --git a/cobalt/network/disk_cache/impl.cc b/cobalt/network/disk_cache/impl.cc
diff --git a/cobalt/renderer/backend/graphics_context.cc b/cobalt/renderer/backend/graphics_context.cc
@@ -31,8 +31,8 @@ GraphicsContext::GraphicsContext(GraphicsSystem* system) : system_(system) {
     // Verify it's the extension needed.
     if (strcmp(graphics_extension_->name, kCobaltExtensionGraphicsName) != 0 ||
         graphics_extension_->version < 1) {
-      LOG(WARNING) << "Not using supplied cobalt graphics extension: "
-                   << "'" << graphics_extension_->name << "' ("
+      LOG(WARNING) << "Not using supplied cobalt graphics extension: " << "'"
+                   << graphics_extension_->name << "' ("
                    << graphics_extension_->version << ")";
       graphics_extension_ = nullptr;
     }

diff --git a/cobalt/web/error_event_test.cc b/cobalt/web/error_event_test.cc
@@ -109,11 +109,9 @@ TEST_P(ErrorEventTestWithJavaScript, ConstructorWithEventTypeAndErrorInitDict) {
   EXPECT_EQ("rulez", result);
 
   if (!success) {
-    DLOG(ERROR) << "Failed to evaluate test: "
-                << "\"" << result << "\"";
+    DLOG(ERROR) << "Failed to evaluate test: " << "\"" << result << "\"";
   } else {
-    LOG(INFO) << "Test result : "
-              << "\"" << result << "\"";
+    LOG(INFO) << "Test result : " << "\"" << result << "\"";
   }
 }
 

diff --git a/cobalt/webdriver/dispatcher.h b/cobalt/webdriver/dispatcher.h
@@ -17,6 +17,7 @@
 
 #include <memory>
 #include <string>
+#include <unordered_map>
 #include <vector>
 
 #include "base/callback.h"

diff --git a/cobalt/webdriver/protocol/button.cc b/cobalt/webdriver/protocol/button.cc
@@ -15,6 +15,7 @@
 #include "cobalt/webdriver/protocol/button.h"
 
 #include <memory>
+#include <utility>
 
 namespace cobalt {
 namespace webdriver {

diff --git a/cobalt/webdriver/protocol/element_id.cc b/cobalt/webdriver/protocol/element_id.cc
@@ -15,6 +15,7 @@
 #include "cobalt/webdriver/protocol/element_id.h"
 
 #include <memory>
+#include <utility>
 
 namespace cobalt {
 namespace webdriver {

diff --git a/cobalt/webdriver/protocol/log_entry.cc b/cobalt/webdriver/protocol/log_entry.cc
@@ -15,6 +15,7 @@
 #include "cobalt/webdriver/protocol/log_entry.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/logging.h"
 

diff --git a/cobalt/webdriver/protocol/size.cc b/cobalt/webdriver/protocol/size.cc
@@ -15,6 +15,7 @@
 #include "cobalt/webdriver/protocol/size.h"
 
 #include <memory>
+#include <utility>
 
 namespace cobalt {
 namespace webdriver {

diff --git a/cobalt/websocket/web_socket_impl.cc b/cobalt/websocket/web_socket_impl.cc
@@ -205,9 +205,8 @@ void WebSocketImpl::OnClose(bool was_clean, int error_code,
 
   std::uint16_t close_code = static_cast<std::uint16_t>(error_code);
 
-  DLOG(INFO) << "WebSocket is closing."
-             << " code[" << close_code << "] reason[" << close_reason << "]"
-             << " was_clean: " << was_clean;
+  DLOG(INFO) << "WebSocket is closing." << " code[" << close_code << "] reason["
+             << close_reason << "]" << " was_clean: " << was_clean;
 
   // Queue the deletion of |websocket_channel_|.  We would do it here, but this
   // function may be called as a callback *by* |websocket_channel_|;