WIP: SB16 POSIX socket test cases update #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
5 times, most recently
from
ae0b8a6
to
d81c4fc
Compare
Datadog ReportBranch report: ✅ 0 Failed, 33878 Passed, 6 Skipped, 22m 23.14s Wall Time |
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
3 times, most recently
from
050e91b
to
155b4a7
Compare
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
from
155b4a7
to
c601ae3
Compare
gbournou
previously requested changes
Apr 16, 2024
starboard/shared/modular/cobalt_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/cobalt_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/cobalt_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/cobalt_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
2 times, most recently
from
648a342
to
a550c7c
Compare
y4vor
reviewed
Apr 17, 2024
starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
from
37b3a56
to
1d55853
Compare
y4vor
approved these changes
Apr 17, 2024
Added POSIX Socket tests cover more IPv4 and IPv6 cases. Converting port numbers from host byte order to network byte order. And some special treatments for PS5: Added a wrapper layer in starboard/shared/moduler to take care of the sockaddr definition differences on certain platform, including accept(), bind(), connect(), getaddrinfo(), getifaddrs(), and setsockopt(). Use a different port number after each use. b/330771976
maxz-lab
force-pushed
the
maxz-sb16-socket-ps5
branch
from
68cba00
to
4d9699c
Compare
auto-merge was automatically disabled
April 19, 2024 14:48
Pull Request is not mergeable
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
May 31, 2024
Added more POSIX Socket tests cover more IPv4 and IPv6 cases. Convered host byte to network byte order for port numbers. Added wrapper layer in starboard/shared/moduler for sockaddr definition differences on certain platform. b/330771976 Co-authored-by: Hao <[email protected]> (cherry picked from commit 5301c80)
kaidokert
pushed a commit
that referenced
this pull request
May 31, 2024
Refer to the original PR: #2904 Added more POSIX Socket tests cover more IPv4 and IPv6 cases. Convered host byte to network byte order for port numbers. Added wrapper layer in starboard/shared/moduler for sockaddr definition differences on certain platform. b/330771976 Co-authored-by: Max Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more POSIX Socket tests cover more IPv4 and IPv6 cases. Convered host byte to network byte order for port numbers. Added wrapper layer in starboard/shared/moduler for sockaddr definition differences on certain platform.
b/330771976