Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Starboard media header description #2958

Merged
merged 1 commit into from
May 8, 2024

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Apr 16, 2024

This PR updates the description in drm.h, decode_target.h, media.h, and player.h. This also fixes formatting issues in PR #2984.

b/326450058

@borongc borongc force-pushed the media_comments branch 5 times, most recently from 69150a7 to cb376aa Compare April 17, 2024 22:59
@borongc borongc changed the title Update starboard media header description Update Starboard media header description Apr 17, 2024
@borongc borongc force-pushed the media_comments branch 3 times, most recently from 15b49dd to fd2db8a Compare April 18, 2024 21:24
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the site generation scripts run on this to verify that the generated docs look correct?

starboard/decode_target.h Show resolved Hide resolved
@borongc borongc force-pushed the media_comments branch 4 times, most recently from 9ce2cae to ff5a02d Compare April 18, 2024 23:31
@borongc
Copy link
Contributor Author

borongc commented Apr 18, 2024

Has the site generation scripts run on this to verify that the generated docs look correct?

Yes, and it fixes the review issues in the PR #2984.

starboard/decode_target.h Outdated Show resolved Hide resolved
starboard/decode_target.h Outdated Show resolved Hide resolved
starboard/drm.h Outdated Show resolved Hide resolved
starboard/drm.h Show resolved Hide resolved
starboard/drm.h Outdated Show resolved Hide resolved
starboard/media.h Outdated Show resolved Hide resolved
starboard/media.h Outdated Show resolved Hide resolved
starboard/player.h Outdated Show resolved Hide resolved
starboard/player.h Outdated Show resolved Hide resolved
starboard/player.h Outdated Show resolved Hide resolved
@borongc borongc force-pushed the media_comments branch 2 times, most recently from 386eb0c to 5c35d70 Compare May 3, 2024 18:16
@borongc borongc requested review from xiaomings and oxve May 3, 2024 18:24
@oxve
Copy link
Contributor

oxve commented May 7, 2024

Looks good from my POV

@borongc borongc force-pushed the media_comments branch 2 times, most recently from 388eed3 to 79a6898 Compare May 7, 2024 21:48
@borongc borongc enabled auto-merge (squash) May 7, 2024 21:50
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@borongc borongc disabled auto-merge May 7, 2024 22:59
@borongc borongc enabled auto-merge (squash) May 8, 2024 00:12
@borongc borongc disabled auto-merge May 8, 2024 02:07
This PR updates the description in drm.h, decode_target.h, media.h, and player.h.

b/326450058
@borongc borongc merged commit 80a62f0 into youtube:main May 8, 2024
299 of 302 checks passed
@borongc borongc deleted the media_comments branch May 8, 2024 03:33
@borongc borongc added cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch labels May 8, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 8, 2024
This PR updates the description in drm.h, decode_target.h, media.h, and
player.h. This also fixes formatting issues in PR
#2984.

b/326450058

(cherry picked from commit 80a62f0)
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 8, 2024
This PR updates the description in drm.h, decode_target.h, media.h, and
player.h. This also fixes formatting issues in PR
#2984.

b/326450058

(cherry picked from commit 80a62f0)
borongc added a commit that referenced this pull request May 8, 2024
This PR updates the description in drm.h, decode_target.h, media.h, and
player.h. This also fixes formatting issues in PR
#2984.

b/326450058

(cherry picked from commit 80a62f0)
borongc added a commit that referenced this pull request May 8, 2024
Refer to the original PR: #2958

This PR updates the description in drm.h, decode_target.h, media.h, and
player.h. This also fixes formatting issues in PR
#2984.

b/326450058

Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants