Add simple MediaSourceAttachment class
#3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registers `MediaSource` objects to the `MediaSourceRegistry` through a `MediaSourceAttachment` proxy. The new `MediaSourceAttachment` class is cross-thread reference counting safe, unlike `MediaSource`, which will allow for utilizing `MediaSource` objects created on Dedicated Workers. This change does not add any additional functionality, and is intended as an incremental update towards enabling the creation of `MediaSource` objects on Dedicated Worker threads. See [Chromium's `MediaSourceAttachment` interface][1], and the commit that [initially introduced it][2]. [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/media/media_source_attachment.h [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2300804 b/338425449 Change-Id: I016c010c9ef4a0e576bd67ce584d75dbe75986ec
xiaomings
reviewed
May 13, 2024
Change-Id: I6e7d522bf99d77a2d81dbbdb6136cb84d51b1d2b
…ment Change-Id: I68d09d664fcd22fe1d2fa5cf4103aacb92cf2cd3
xiaomings
approved these changes
May 14, 2024
aee-google
approved these changes
May 15, 2024
at-ninja
added
cp-25.lts.1+
auto-merge was automatically disabled
May 17, 2024 17:06
Pull Request is not mergeable
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
May 17, 2024
Registers `MediaSource` objects to the `MediaSourceRegistry` through a `MediaSourceAttachment` proxy. The new `MediaSourceAttachment` class is cross-thread reference counting safe, unlike `MediaSource`, which will allow for utilizing `MediaSource` objects created on Dedicated Workers. This change does not add any additional functionality, and is intended as an incremental update towards enabling the creation of `MediaSource` objects on Dedicated Worker threads. See [Chromium's `MediaSourceAttachment` interface][1], and the commit that [initially introduced it][2]. [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/media/media_source_attachment.h [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2300804 b/338425449 Change-Id: I016c010c9ef4a0e576bd67ce584d75dbe75986ec (cherry picked from commit 29e0d65)
at-ninja
added a commit
that referenced
this pull request
May 20, 2024
Refer to the original PR: #3232 Registers `MediaSource` objects to the `MediaSourceRegistry` through a `MediaSourceAttachment` proxy. The new `MediaSourceAttachment` class is cross-thread reference counting safe, unlike `MediaSource`, which will allow for utilizing `MediaSource` objects created on Dedicated Workers. This change does not add any additional functionality, and is intended as an incremental update towards enabling the creation of `MediaSource` objects on Dedicated Worker threads. See [Chromium's `MediaSourceAttachment` interface][1], and the commit that [initially introduced it][2]. [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/media/media_source_attachment.h [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2300804 b/338425449 Change-Id: I016c010c9ef4a0e576bd67ce584d75dbe75986ec Co-authored-by: Drew Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers
MediaSourceobjects to theMediaSourceRegistrythrough aMediaSourceAttachmentproxy. The newMediaSourceAttachmentclass is cross-thread reference counting safe, unlikeMediaSource, which will allow for utilizingMediaSourceobjects created on Dedicated Workers.This change does not add any additional functionality, and is intended as an incremental update towards enabling the creation of
MediaSourceobjects on Dedicated Worker threads.See Chromium's
MediaSourceAttachmentinterface, and the commit that initially introduced it.b/338425449
Change-Id: I016c010c9ef4a0e576bd67ce584d75dbe75986ec