Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instruction which enable evergreen on AOSP #3699

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jonastsai
Copy link
Contributor

Update build instruction to support evergreen on AOSP

b/318730771

Copy link

@lamdbui lamdbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonastsai . Put some suggestions for you to review here.

cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Show resolved Hide resolved
@jonastsai jonastsai force-pushed the b-318730771 branch 8 times, most recently from b0d70db to 9f222b6 Compare June 28, 2024 12:21
@jonastsai jonastsai force-pushed the b-318730771 branch 3 times, most recently from 65e40b2 to 5b42d87 Compare July 10, 2024 06:09
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.80%. Comparing base (bf2e706) to head (5b42d87).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3699   +/-   ##
=======================================
  Coverage   57.80%   57.80%           
=======================================
  Files        1779     1779           
  Lines       86476    86496   +20     
=======================================
+ Hits        49985    50002   +17     
- Misses      36491    36494    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lamdbui lamdbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonas. We can follow-up with Android Studio instructions later. I still think it'll be a good idea to have them, if it's all functional and a workflow that is used for development.

@jonastsai jonastsai marked this pull request as ready for review July 10, 2024 23:26
@jonastsai jonastsai enabled auto-merge (squash) July 10, 2024 23:35
@jonastsai jonastsai disabled auto-merge July 11, 2024 00:34
@jonastsai jonastsai merged commit 314adcd into youtube:main Jul 11, 2024
317 of 318 checks passed
@oxve oxve added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Sep 19, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 19, 2024
Update build instruction to support evergreen on AOSP

b/318730771

(cherry picked from commit 314adcd)
oxve pushed a commit that referenced this pull request Sep 19, 2024
Update build instruction to support evergreen on AOSP

b/318730771
oxve pushed a commit that referenced this pull request Sep 19, 2024
Refer to the original PRs:
* #3699
* #3855
* #4108

b/318730771
b/361540371
b/362655498

---------

Co-authored-by: Jonas Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants