Using socket_posix to replace socket_starboard #3904
Merged
+523
−735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
from
a6ac9da
to
92ce2b0
Compare
Datadog ReportBranch report: ✅ 0 Failed, 33856 Passed, 6 Skipped, 7m 17.7s Total Time |
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
7 times, most recently
from
f14ab03
to
aaf0f38
Compare
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
3 times, most recently
from
1210dd6
to
e221129
Compare
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
8 times, most recently
from
9ffed3b
to
11c4097
Compare
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
7 times, most recently
from
6f6b89f
to
a4422f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
- Coverage 57.75% 57.59% -0.16%
==========================================
Files 1779 1746 -33
Lines 86573 86323 -250
==========================================
- Hits 50001 49722 -279
- Misses 36572 36601 +29 ☔ View full report in Codecov by Sentry. |
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
4 times, most recently
from
32942d6
to
abc4776
Compare
|
Can you first make sure all the tests pass? |
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
4 times, most recently
from
6c1f2c5
to
72d5274
Compare
y4vor
approved these changes
Sep 12, 2024
jellefoks
reviewed
Sep 12, 2024
jellefoks
reviewed
Sep 12, 2024
jellefoks
reviewed
Sep 12, 2024
jellefoks
reviewed
Sep 12, 2024
jellefoks
reviewed
Sep 12, 2024
Using base/starboard implementation to work with net/tcp&udp. Combine read and write waiter into one to match starboard's setup. Updated some win32 test cases treat "\r" and "\r\n" Check evergreen bind with IPv6 err b/302741384
maxz-lab
force-pushed
the
maxz-sb16-sock-netposix
branch
from
8e62453
to
abc343d
Compare
johnxwork
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace net/tcp&udp_starboard with net/tcp&udp_posix.
b/302741384